(build) Switch to using Web Targets NuGet Package

chocolatey-community / simple-server

The Chocolatey Simple Server - https://community.chocolatey.org/packages/chocolatey.server

Apache License 2.0

44 stars 17 forks source link

(build) Switch to using Web Targets NuGet Package #38

Closed gep13 closed 6 years ago

gep13 commented 6 years ago

I didn't have the specific Web Targets on my VM
Using this NuGet package means that it should build on any machine

gep13 commented 6 years ago

@ferventcoder what are your thoughts on this addition?

ferventcoder commented 6 years ago

Looks good, but why is this necessary when it uses _PublishedApplications targets? Do they make reference to this file?

Ignore this. I was thinking of something else when I left this comment.

ferventcoder commented 6 years ago

Once you have this rebased and ready, let me know and I'll merge it in.

gep13 commented 6 years ago

@ferventcoder I believe I have made the necessary changes here. Let me know if you spot anything else.

ferventcoder commented 6 years ago

Merged into master at https://github.com/chocolatey/simple-server/commit/639b28dfb8a7a68c36e3670780426904113ee16d

ferventcoder commented 6 years ago

No idea what the issue was, but I had to revert this just now. Once switched it does not properly create the _PublishedWebsites folder, causing running build.bat to break.