Closed corbob closed 1 year ago
~I've made an executative decision about something to do with the MSI builds, and so put this in Draft. I think this change will make sense and be better than #105 since the implementation of the new method would be identical for all scenarios I can think of.~
To clarify: #105 initially suggested adding an UploadArtifacts
method that accepts a new filename to upload. After making this PR, I started to think about how to do that. It occurred to me that no matter how you change it, this would be implemented the same way across all providers. Instead of implementing basically the same code, I figured we should just do the rename in the Build-MSI task.
@corbob thanks for getting this fixed up!
Description Of Changes
Upload the MSI when the signing step completes.
Motivation and Context
Building the MSI doesn't have much purpose if we don't make it available as an artifact to the build provider.
Testing
tools/Chocolatey.Cake.Recipe.0.21.0/
directory ofchocolatey/choco
repository.2.0.0-beta-20230321
tag./build.bat --verbosity=diagnostic --target=CI --testExecutionType=none --shouldRunOpenCover=false
-unsigned
.Operating Systems Testing
Windows 10 22H2
Change Types Made
Change Checklist
Related Issue
Fixes #106