chocolatey / Chocolatey.Cake.Recipe

A set of convention based Cake scripts for building Chocolatey projects
Apache License 2.0
5 stars 9 forks source link

Task "Publish-GitHub-Release" doesn't run when on a Support Branch #135

Open gep13 opened 5 months ago

gep13 commented 5 months ago

Checklist

What You Are Seeing?

When attempting to run build.bat --target="publish-github-release" while on a Support Branch, the task can't be executed.

This is due to this condition:

https://github.com/chocolatey/Chocolatey.Cake.Recipe/blob/8efe5c51e21293bf08545943f75370e3316fab92/Chocolatey.Cake.Recipe/Content/gitreleasemanager.cake#L87

Which doesn't account for running on a Support Branch, only while on Master, Release, and HotFix.

What is Expected?

The Task should be reachable, and execute correctly, since deploying a release from a Support Branch is something that we do, and needs to work.

How Did You Get This To Happen?

  1. Run build.bat --target="publish-github-release" from a support branch
  2. See that it can't be reached

System Details

Installed Packages

N/A

Output Log

N/A

Additional Context

There is a related issue about renaming this task.