Closed Windos closed 5 months ago
@gep13 - Thanks for your input on this PR, I swapped over to Tool Settings for my change. I also got this change tested today, it highlighted that the path to the batch file needed an explicit ToString()
.
@Windos this looks great! Happy to get this merged in, and get a new release out the door!
Description Of Changes
This PR enables disabling the Dependency-Check Yarn Audit analysis as part of the Dependency-Check task. Due to the Dependency-Check Cake addin being out of date, this is achieved by injecting the required switch into the
dependency-check.bat
when a new tool setting, dependencyCheckDisableYarnAudit, is set totrue
.Motivation and Context
Dependency-Check occasionally triggers Yarn analysis when it isn't needed and results in the Dependency-Check failing. By disabling this analysis, it allows the Dependency-Check, and build in general, to complete successfully.
Testing
.\build.bat --verbosity=diagnostic --target=CI --testExecutionType=none --shouldRunAnalyze=false --shouldRunIlMerge=false --shouldObfuscateOutputAssemblies=false --shouldRunChocolatey=false --shouldRunNuGet=false --shouldRunSonarQube=true --shouldRunDependencyCheck=true
--dependencyCheckDisableYarnAudit=true
Operating Systems Testing
Windows Server 2019
Change Types Made
Change Checklist
Related Issue