[X] I have verified this is the correct repository for opening this issue.
[X] I have verified no other issues exist related to my problem.
[X] I have verified this is not an issue for a specific package.
[X] I have verified this issue is not security related.
[X] I confirm I am using official, and not unofficial, or modified, Chocolatey products.
What You Are Seeing?
When running a build with 0.28.1 of Chocolatey.Cake.Recipe, the verify signing task is running when running a Pull Request build.
Initially, it was thought that this would be fine, however, this will stop people from using the output of a Pull Request build from doing further testing of the package, which is bad.
What is Expected?
The Pull Request build should skip running the verify signing task, that way, the artifacts can be generated, and additional testing performed.
The signing step should run on any releaseable branch, i.e. master, develop, hotfix, etc. and continue to fail the build there if there is a mismatch in signatures. Then a task can be performed to update the signatures, when required.
How Did You Get This To Happen?
Ran PR build on chocolatey/choco, and it failed for invalid signatures.
Checklist
What You Are Seeing?
When running a build with 0.28.1 of Chocolatey.Cake.Recipe, the verify signing task is running when running a Pull Request build.
Initially, it was thought that this would be fine, however, this will stop people from using the output of a Pull Request build from doing further testing of the package, which is bad.
What is Expected?
The Pull Request build should skip running the verify signing task, that way, the artifacts can be generated, and additional testing performed.
The signing step should run on any releaseable branch, i.e. master, develop, hotfix, etc. and continue to fail the build there if there is a mismatch in signatures. Then a task can be performed to update the signatures, when required.
How Did You Get This To Happen?
Ran PR build on chocolatey/choco, and it failed for invalid signatures.
System Details
N/A
Installed Packages
Output Log
Additional Context
N/A