chocolatey / Chocolatey.Cake.Recipe

A set of convention based Cake scripts for building Chocolatey projects
Apache License 2.0
5 stars 9 forks source link

Verify signing task should not run on Pull Request builds #153

Closed gep13 closed 4 months ago

gep13 commented 4 months ago

Checklist

What You Are Seeing?

When running a build with 0.28.1 of Chocolatey.Cake.Recipe, the verify signing task is running when running a Pull Request build.

Initially, it was thought that this would be fine, however, this will stop people from using the output of a Pull Request build from doing further testing of the package, which is bad.

What is Expected?

The Pull Request build should skip running the verify signing task, that way, the artifacts can be generated, and additional testing performed.

The signing step should run on any releaseable branch, i.e. master, develop, hotfix, etc. and continue to fail the build there if there is a mismatch in signatures. Then a task can be performed to update the signatures, when required.

How Did You Get This To Happen?

Ran PR build on chocolatey/choco, and it failed for invalid signatures.

System Details

N/A

Installed Packages

N/A

Output Log

N/A

Additional Context

N/A

choco-bot commented 4 months ago

:tada: This issue has been resolved in version 0.28.2 :tada:

The release is available on:

Your GitReleaseManager bot :package: :rocket: