chocolatey / Chocolatey.Cake.Recipe

A set of convention based Cake scripts for building Chocolatey projects
Apache License 2.0
5 stars 9 forks source link

(#155) Keep directory structure for signed PowerShell scripts #156

Closed AdmiringWorm closed 1 month ago

AdmiringWorm commented 1 month ago

Description Of Changes

This updates how scripts that are signed will be handled, by using the same directory structure in the output folder as is relative for the now new parameter for a Root Folder. It also updates how the artifacts are created and uploaded by first create a zip archive of the files hile preserving the directory structure, and then upload only the zip archive.

Motivation and Context

To allow multiple files with the same name to be signed, without the files overwriting eachother, as well as making it easier in the future when we have signed scripts and only need to download a single file that can be extracted immediately to the correct locations.

Testing

This has been tested manually by running the signing process locally, while commenting out the necessary parts that would fail if no signing keys are present. The verification was that everything was copied to the correct directory structure, a zip archive was created with the same directory structure expected and it uploaded it to the artifacts directory.

Operating Systems Testing

Change Types Made

Change Checklist

Related Issue

Fixes #155

gep13 commented 1 month ago

@AdmiringWorm thanks for getting this fixed!