search

chocolatey / Chocolatey.Cake.Recipe

A set of convention based Cake scripts for building Chocolatey projects
Apache License 2.0
5 stars 9 forks source link

SolutionVersion is generated unnecessarily #66

Closed gep13 closed 2 years ago

gep13 commented 2 years ago

When building a full fat .NET Framework application, generating a SolutionVersion.cs file is very useful (as this file can be shared across all the projects, so that the version numbers stamped on the assemblies are always the same). However, when doing dotnet cli based projects, this SolutionVersion.cs file is not really needed, as there are different ways (directory.props, etc) that shared information can be shared between projects. As such, always generating this file is not required, and it should be possible to configure when this should happen.

This will be done via a parameter in the SetParameters method. By default, it should generate the SolutionVersion.cs, as the majority of our projects still use it. In future, this default value may change.

gep13 commented 2 years ago

This has been implemented.

Adding:

shouldGenerateSolutionVersionCSharpFile: false

in the recipe.cake file will prevent the SolutionVersion.cs file from being generated.

gep13 commented 2 years ago

@corbob you should be able to use this in the Rhino.Licensing build.

choco-bot commented 2 years ago

:tada: This issue has been resolved in version 0.14.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: