chocolatey / Chocolatey.Cake.Recipe

A set of convention based Cake scripts for building Chocolatey projects
Apache License 2.0
5 stars 9 forks source link

Remove usage of SNRemove #68

Closed gep13 closed 1 year ago

gep13 commented 2 years ago

Is Your Feature Request Related To A Problem? Please describe.

SNRemove was added to the Chocolatey.Cake.Recipe as it was believed that it would be possible to remove the official Strong Name Key from the referenced Chocolatey assemblies, replacing it with the public Strong Name Key. In doing this, it would be possible to perform a debug build to locally run any Chocolatey product without additional work. However, this turns out not to be the case...

It is believed that stripping the Strong Name Key from an obfuscated assembly is causing the execution of that assembly to fail.

Describe The Solution. Why is it needed?

We should completely remove the usage of the SNRemove tool, and leave the existing Strong Name Key in place for all Chocolatey assemblies.

Additional Context.

When required, it will be necessary to fall back to using the old Get-ChocolateyDebugBuild script, which replaces the referenced assemblies with a freshly build, debug version, of the Chocolatey assemblies.

Related Issues

N/A