chocolatey / Chocolatey.Cake.Recipe

A set of convention based Cake scripts for building Chocolatey projects
Apache License 2.0
5 stars 9 forks source link

Remove modification of strong name key from reference Chocolatey assemblies #72

Closed gep13 closed 1 year ago

gep13 commented 1 year ago

Is Your Feature Request Related To A Problem? Please describe.

When building Chocolatey Agent, the modification to the strong name key of the referenced Chocolatey assemblies results in a build that doesn't work as expected. As such, we need to remove the modifications of the strong name key, leaving them intact.

Describe The Solution. Why is it needed?

One of the original goals of the Chocolatey.Cake.Recipe build system was to make it easier to switch between debug/release/official builds, meaning that you wouldn't have to worry about what assemblies was being used. The build system was going to take care of stripping off any existing strong name key applied to the assemblies, replacing it with the correct one for the build that was currently being done. When this was testing out building Chocolatey Central Management, this seemed to work exactly as expected so it was rolled out to the Chocolatey Licensed and Chocolatey Agent repositories. When this was done, it was found that the Chocolatey Agent build didn't complete correctly when being built on a machine without the official signing keys in place.

Additional Context.

It is unfortunate that we are not able to get this to work currently, and it is believed that the issue is related to the fact that the assemblies are also obfuscated, in addition to being strong name signed. The workaround for not having this ability will be to defer to the original way of bringing in a new Chocolatey dependency and to run the Get-ChocoUpdatedDebugVersion.ps1 script when required.

Related Issues

N/A

choco-bot commented 1 year ago

:tada: This issue has been resolved in version 0.16.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: