chocolatey / ChocolateyGUI

A delicious GUI for Chocolatey
https://docs.chocolatey.org/en-us/chocolatey-gui/
Apache License 2.0
1.61k stars 248 forks source link

(doc) Confirm WCAG Compliance #1054

Open pauby opened 1 week ago

pauby commented 1 week ago

Description Of Changes

Confirms WCAG Compliance of Chocolatey GUI and what to use for accessibility.

Motivation and Context

Chocolatey GUI is not WCAG compliant.

Testing

N/A - this is markdown.

Operating Systems Testing

N/A

Change Types Made

Change Checklist

Related Issue

Fixes #645

gep13 commented 1 week ago

@pauby since there is an issue associated with this PR that is already on the 2.2.0 milestone, this PR shouldn't also be added to the milestone.

Or, should we remove the linked issue from the milestone, and close it out as not being completed, and leave this documentation PR in that milestone?

pauby commented 1 week ago

This was my fault. I added this PR then remembered I should add the issue instead and then forgot to remove this again.

Removed this PR.

gep13 commented 1 week ago

Removed this PR.

Thanks for doing that.

Regarding, #645, I am not sure if it is right to say that this PR addresses that issue. Chocolatey GUI has not been tested with a suitable screenreader, and the accessibility changes haven't been made. I think the wording of that issue needs to be changed, or this PR should not be attributed to that issue, and instead it should be closed.

pauby commented 1 week ago

My thinking on the issue being 'fixed' by the PR was that as Chocolatey CLI should be used when accessibility tools are used, and we are stating that in the 'About' screen, the issue was no longer required.

I attributed the issue as the changes in this PR is the reason it a being closed.

I have no problem with not linking it in the PR as it being 'fixed', instead closing it by referencing the PR in the closure comment.