search

chocolatey / ChocolateyGUI

A delicious GUI for Chocolatey
https://docs.chocolatey.org/en-us/chocolatey-gui/
Apache License 2.0
1.65k stars 251 forks source link

(#993) (ENGTASKS-2347) Run integration tests only on scheduled builds #994

Closed Windos closed 1 year ago

Windos commented 1 year ago

NOTE: This PR should not be merged until Chocolatey CLI v2.0.0 has been released. This repo also currently does not differentiate between unit and integration tests (if I'm reading things correctly), so merging may need to wait until that is the case.

Description Of Changes

This PR adds a schedule trigger to the TeamCity build, and also adjust the build so that it selects which tests to run based on how the build was triggered.

It also adjusts the GitHub workflow for pushes and pull requests to only run unit tests.

Motivation and Context

Integration tests take a long time to run, and do not need to be run on every commit. Reducing the tests run on each commit to only unit tests will speed up the feedback loop.

Running full integration tests on a schedule means that we still benefit from the coverage they give without slowing down the "in the moment" feedback.

Testing

Equivalent Kotlin changes submitted to chocolatey/choco have been tested on a non-production TeamCity instance.

Operating Systems Testing

N/A

Change Types Made

N/A

Change Checklist

N/A

Related Issue

gep13 commented 1 year ago

@Windos thanks for fixing this up! I am ok with this going in just now, even though there aren't currently any integration tests in play.