(GH-61) Fix choco install package result

[esiebes]

edit comments from pullrequest 102

Supersedes #102

Related to #61

[esiebes]

new pullrequest originally pullrequest 102.

[pauby]

@esiebes Is this still a PR you are wanting to work on?

[esiebes]

yes, i will work on it asap

Op zo 28 jul. 2019 16:42 schreef Paul Broadwith notifications@github.com:

@esiebes https://github.com/esiebes Is this still a PR you are wanting to work on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chocolatey/cChoco/pull/103?email_source=notifications&email_token=AIEO72WOUTKY5QGHITNINVDQBWV4DA5CNFSM4EIE6TEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27AA2I#issuecomment-515768425, or mute the thread https://github.com/notifications/unsubscribe-auth/AIEO72WVMNTQ2JGIIONXJM3QBWV4DANCNFSM4EIE6TEA .

[pauby]

@esiebes Are you still working on this?

[pauby]

@esiebes Are you still wanting to take this forward?

[esiebes]

Yes, will forward the changes tomorrow.

Op do 21 mei 2020 18:01 schreef Paul Broadwith notifications@github.com:

@esiebes https://github.com/esiebes Are you still wanting to take this forward?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chocolatey/cChoco/pull/103#issuecomment-632176997, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIEO72RTB2W56QDGKCM4DGTRSVF45ANCNFSM4EIE6TEA .

[esiebes]

I keep getting a failed test in appveyor on the psscriptanalyzer test. Local on my machine i dont get it. Someon an idea? [-] passes the PSScriptAnalyzer Rule PSShouldProcess 986ms Expected 0, but got 1. [-] passes the PSScriptAnalyzer Rule PSShouldProcess 986ms Expected 0, but got 1. 34: (Invoke-ScriptAnalyzer -Path $module.FullName -IncludeRule $rule.RuleName ).Count | Should Be 0 at , C:\projects\cchoco\tests\cChoco_ScriptAnalyzerTests.ps1: line 3434: (Invoke-ScriptAnalyzer -Path $module.FullName -IncludeRule $rule.RuleName ).Count | Should Be 0 at , C:\projects\cchoco\tests\cChoco_ScriptAnalyzerTests.ps1: line 34

[pauby]

Are you running the same version of PSScriptAnalzyer?

Can I also ask you to update some of those commit messages and preferably squash some of them?

[esiebes]

I will do that. Whih versiin is used?

Op di 23 jun. 2020 13:28 schreef Paul Broadwith notifications@github.com:

Are you running the same version of PSScriptAnalzyer?

Can I also ask you to update some of those commit messages and preferably squash some of them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chocolatey/cChoco/pull/103#issuecomment-648086091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIEO72VIAGJFDTYI35357TLRYCGWBANCNFSM4EIE6TEA .

[pauby]

See this for the maximum version that the author believes is supported.

Also see this issue #147 for the build issues.