search

chocolatey / cChoco

Community resource to manage Chocolatey
Apache License 2.0
154 stars 99 forks source link

New Resource for managing choco config #132

Closed mrhockeymonkey closed 4 years ago

mrhockeymonkey commented 5 years ago

This is in answer to #20 and partly related to #124.

This resource allows control over config settings via "choco config set/unset. It also has an option for querying the xml settings file directly. This is for performance reasons as discussed in #124. It is optional and not recommended for ongoing management but makes the resource much quicker, 2.82 seconds vs 0.68 seconds (see sample output below).

Sample output:

# normal mode
VERBOSE [SURFACE]: LCM:[ Start  Set]
VERBOSE [SURFACE]:[DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\cChoco\DscResources\cChocoConfig\cChocoConfig.psm1 in force mode.
VERBOSE [SURFACE]: LCM:  [ Start  Resource ]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE [SURFACE]: LCM:  [ Start  Test]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE [SURFACE]:[[cChocoConfig]webRequestTimeoutSeconds] Importing the module cChocoConfig in force mode.
VERBOSE [SURFACE]:[[cChocoConfig]webRequestTimeoutSeconds] Querying choco config via CLI
VERBOSE [SURFACE]:[[cChocoConfig]webRequestTimeoutSeconds] webRequestTimeoutSeconds is in desired state
VERBOSE [SURFACE]: LCM:  [ End    Test]  [[cChocoConfig]webRequestTimeoutSeconds]  in 1.9260 seconds.
VERBOSE [SURFACE]: LCM:  [ Skip   Set]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE [SURFACE]: LCM:  [ End    Resource ]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE [SURFACE]: LCM:  [ End    Set]
VERBOSE [SURFACE]: LCM:  [ End    Set]    in  2.8210 seconds.   

# querying xml directly
VERBOSE: [SURFACE]: LCM:  [ Start  Set]
VERBOSE: [SURFACE]:[DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\cChoco\DscResources\cChocoConfig\cChocoConfig.psm1 in force mode.
VERBOSE: [SURFACE]: LCM:  [ Start  Resource ]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE: [SURFACE]: LCM:  [ Start  Test]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE: [SURFACE]:[[cChocoConfig]webRequestTimeoutSeconds] Importing the module cChocoConfig in force mode.
VERBOSE: [SURFACE]:[[cChocoConfig]webRequestTimeoutSeconds] Querying chco config via chocolatey.config xml...
VERBOSE: [SURFACE]:[[cChocoConfig]webRequestTimeoutSeconds] webRequestTimeoutSeconds is in desired state
VERBOSE: [SURFACE]: LCM:  [ End    Test]  [[cChocoConfig]webRequestTimeoutSeconds]  in 0.4470 seconds.
VERBOSE: [SURFACE]: LCM:  [ Skip   Set]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE: [SURFACE]: LCM:  [ End    Resource ]  [[cChocoConfig]webRequestTimeoutSeconds]
VERBOSE: [SURFACE]: LCM:  [ End    Set]
VERBOSE: [SURFACE]: LCM:  [ End    Set]    in  0.6830 seconds.

feedback welcome.

pauby commented 4 years ago

@mrhockeymonkey You've added two previous commits in your PR. Can you remove those?

pauby commented 4 years ago

This is being superceded by #145. Closing.