multiversion install and optimize choco install

chocolatey / cChoco

Community resource to manage Chocolatey

Apache License 2.0

154 stars 99 forks source link

multiversion install and optimize choco install #141

Closed wizarden1 closed 4 years ago

wizarden1 commented 4 years ago

Fixes and changes:

remove trailing spaces for newer version of test
rebuild cChocoPackageInstall for multi version install
rewrite cChocoInstaller for use nuget source(chocolate nuget source) directly
add example how to use multiple version

pauby commented 4 years ago

@wizarden1 Can you break this PR into two separate ones - 'multiversion install' and 'optimize choco install'? Makes it easier to review.

Can I also ask you to create a feature branch and PR from that rather than your own development branch?

On first glance the code you've submitted doesn't adhere to the current code style - can I ask you to make sure it does?

wizarden1 commented 4 years ago

@wizarden1 Can you break this PR into two separate ones - 'multiversion install' and 'optimize choco install'? Makes it easier to review.

Yes. Sure, no problem.

Can I also ask you to create a feature branch and PR from that rather than your own development branch?

Also, no problem.

On first glance the code you've submitted doesn't adhere to the current code style - can I ask you to make sure it does?

How, and what do you mean?

pauby commented 4 years ago

How, and what do you mean?

The two that jumped out on a quick glance over were if / else statements should not be on a single line and datatypes should be lowercase and don't need System. in them (ie. System.String). There will likely be others (I'm updating the contribution guidelines just now).

wizarden1 commented 4 years ago

How, and what do you mean?

The two that jumped out on a quick glance over were if / else statements should not be on a single line and datatypes should be lowercase and don't need System. in them (ie. System.String). There will likely be others (I'm updating the contribution guidelines just now).

Ok, I'll recheck and fix. Thanks.

pauby commented 4 years ago

This has been superceded by #142 and #143 .