[cChocoInstaller] Do not create install dir prior to calling install.ps1 script

xadozuk commented 10 months ago

Description Of Changes

Change cChocoInstaller resource to not create the install dir before calling the install.ps1 file.

Motivation and Context

Following change in the install.ps1 file, chocolatey installation will stop if the target installation path exists (even if empty); Ref: https://github.com/chocolatey/home/issues/276

Testing

Run the following DSC configuration with the changed module:

Configuration InstallChoco {
Import-DSCResource -ModuleName cChoco

cChocoInstaller "ChocoInstall"
{
    installDir = "C:\ProgramData\chocolatey"
}
}

Installation is successful

Operating Systems Testing

Windows Server 2022

Change Types Made

[x] Bug fix (non-breaking change).
[ ] Feature / Enhancement (non-breaking change).
[x] Breaking change (fix or feature that could cause existing functionality to change).
- Not sure of the change scope
[ ] Documentation changes.
[ ] PowerShell code changes.

Change Checklist

[ ] Requires a change to the documentation.
[ ] Documentation has been updated.
[ ] Tests to cover my changes, have been added.
[ ] All new and existing tests passed?
[ ] PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #179

doherty100 commented 10 months ago

@vexx32 just wondering how it will take to get a new release published for those of us that consume cChoco as an Azure Automation module?

jackmtpt commented 10 months ago

Following this thread as well - can we get a new release published with this fix in it? The current 2.5.0 module is essentially unusable now since it cannot install choco anymore.

pauby commented 10 months ago

@doherty100 @jackmtpt Please see this comment for information about a release.

chocolatey / cChoco