chocolatey / cChoco

Community resource to manage Chocolatey
Apache License 2.0
153 stars 99 forks source link

cChoco uninstalls, then reinstall if package is out of date. #95

Open lukegriffith opened 7 years ago

lukegriffith commented 7 years ago

https://github.com/chocolatey/cChoco/blob/6b8f5a5b56709c58c4b40b0290ff6e75e9c02898/DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1#L99

Resource, when provided with a version number and an out of date package will uninstall the current version and reinstall the newer - leading to unwanted behavior with some

ferventcoder commented 7 years ago

This may cause some weirdness when you use cChoco to keep Chocolatey itself updated.

lukegriffith commented 6 years ago

Have a hot fixed branch of this, but without a complete refactor the patch adds another call to choco list what's isn't very optimised.

ferventcoder commented 6 years ago

@lukemgriffith we can get started on looking at the PR and move from there to make it more optimized.

lukegriffith commented 6 years ago

https://github.com/chocolatey/cChoco/pull/92 might help make my fix be more optimized.

pauby commented 5 years ago

@lukemgriffith #92 has been merged.

alphakilo45 commented 4 years ago

The uninstall / reinstall behavior is causing problems for my project as well. @lukemgriffith Is there anything I can do to help with your hotfix? Or is this issue truly up for grabs if I wanted to take a crack at it?

lukegriffith commented 4 years ago

Been a long time since I've worked on this. I cant remember anything of my PR please go ahead :)