[Enhancement] Support Higher Encryption like SHA256

chocolatey / checksum

Validates MD5/SHA1 CheckSums on the command line.

Apache License 2.0

14 stars 13 forks source link

[Enhancement] Support Higher Encryption like SHA256 #1

Closed ferventcoder closed 7 years ago

ferventcoder commented 9 years ago

[x] SHA256
[x] SHA512

jberezanski commented 8 years ago

How about switching from explicitly creating the various hash algorithm implementations to the HashAlgorithm.Create() method? You could pass configuration.HashType directly to the method, gaining automatic support for all current and future hashes supported by .NET.

ferventcoder commented 8 years ago

Already looking at doing that - evolutionary design. :)

ferventcoder commented 8 years ago

@stefanscherer over here

StefanScherer commented 8 years ago

@ferventcoder Thanks. Haven't done any C# yet and trying to "connect the dots". As it seems the suggestion with HashAlgorithm.Create() seems the right way to do it.

ferventcoder commented 8 years ago

Yep. The current solution here is a very YAGNI implementation. Adding in another type necessitates the need for refactoring. :)

dragon788 commented 7 years ago

@ferventcoder I've noticed some packages using sha256 now, is this already implemented?

ferventcoder commented 7 years ago

Yes. Forgot to close this. Thanks for the reminder.

ferventcoder commented 7 years ago

https://github.com/ferventcoder/checksum/commit/c212eb102179a512087ccf371c505ac8e1b9632a