chocolatey / choco-quickstart-scripts

C4B Quick-Start Guide - Supporting Scripts
Apache License 2.0
16 stars 8 forks source link

(#216) Move jenkins credential logic to helpers #217

Closed steviecoaster closed 5 months ago

steviecoaster commented 8 months ago

Description Of Changes

This PR creates several new helper functions which cleans up the logic in the Jenkins setup step of the guide, and gives us greater control over what happens.

Motivation and Context

We encountered an edge case where the credential written to the README differed from the initial jenkins config file.

Testing

N/A at this time.

Operating Systems Testing

N/A at this time.

Change Types Made

Change Checklist

Related Issue

Fixes #216

steviecoaster commented 8 months ago

@JPRuskin it's impossible to say what happened, but moving these out to helpers will allow support to "fix it" relatively easily.