chocolatey / choco-quickstart-scripts

C4B Quick-Start Guide - Supporting Scripts
Apache License 2.0
16 stars 8 forks source link

(#223) Removes Chocolatey Install Script from Repository #233

Closed JPRuskin closed 3 months ago

JPRuskin commented 5 months ago

Description Of Changes

The QSG now pulls the latest-current version at install time, which means we no longer have to keep it updated in two places.

Additionally, it allows for overriding the script by downloading it in advance to the specified location. This may or may not solve #227.

Finally, there's a little bit of "check that it's signed by us" logic, which is arguably fairly unhelpful - but might prevent folk getting a copy that says "This PS1 file has been flagged by $Antivirus", at the very least.

Motivation and Context

There was a copy of the script available in the

Testing

Operating Systems Testing

Change Types Made

Change Checklist

Related Issue

Fixes #223

ryanrichter94 commented 3 months ago

Waiting to merge. Want to have discussion on if this truly fixes #227 before doing so.