chocolatey / choco-quickstart-scripts

C4B Quick-Start Guide - Supporting Scripts
Apache License 2.0
18 stars 9 forks source link

ClientSetup Enhancements - Parameterize script to allow for additional flexibility #240

Open ryanrichter94 opened 7 months ago

ryanrichter94 commented 7 months ago

Checklist

Is Your Feature Request Related To A Problem? Please describe.

Through customer interaction these are the nice additions we feel would be well received to edit within ClientSetup

Describe The Solution. Why is it needed?

These enhancements would make the ClientSetup script more flexible by providing parameters to the script to support more customizable installs.

Additional Context

No response

Related Issues

No response

steviecoaster commented 1 month ago

This could be done with additional parameters:

[Parameter()]
[Hashtable[]]
$AdditionalPackages,

[Parameter()]
[Hashtable[]]
$AdditionalConfiguration

We could then just act on it at the end of ClientSetup:

if($AdditionalPackages){
  #action here
}

if($AdditionalConfiguration){
  #Action here
}
JPRuskin commented 1 week ago

If doing AdditionalPackages can I suggest that we trigger the Jenkins job (like we do in Azure / Ansible) rather than adding further logic?

See: https://github.com/chocolatey/c4b-azure/blob/main/source/Initialise-C4B.ps1#L174-L184