search

chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.38k stars 904 forks source link

Chocolatey is removing files with no extensions in the filename #1175

Open dschepler opened 7 years ago

dschepler commented 7 years ago

What You Are Seeing?

When we install a package from our local repository containing files with no extensions in the filenames (e.g. scalable-3p-eigen3\tools\include\eigen3\Eigen\Core), those files are getting removed after unpacking but before running the post-install script. They're definitely present in the .nupkg file, and NuGet.exe (version 3.4.3.855 from choco install NuGet.CommandLine) is able to extract it without the files disappearing.

What is Expected?

The files should not be deleted -- they weren't deleted in older Chocolatey versions.

This used to work fine with older Chocolatey versions up until about a couple weeks or maybe a month ago (though we don't have an exact version number where it stopped working).

How Did You Get This To Happen? (Steps to Reproduce)

Chocolatey version: 0.10.3 choco install scalable-3p-eigen3 -y --force

If you need the exact nupkg files to test with, there won't be an issue with sending them over private email or posting them somewhere public, since Eigen3 is FOSS anyway.

Output Log

GIST LINK - https://gist.github.com/dschepler/7d3c070aff73269c27240279e672969a

ferventcoder commented 7 years ago

@dschepler If you can provide that package, that would be great.

Note there is some weird issue where NuGet.Core isn't extracting any binaries that have no extensions - https://gist.github.com/dschepler/7d3c070aff73269c27240279e672969a#file-choco-log-txt-L3227-L3659

The next thing to determine is why it is doing this.

dschepler commented 7 years ago

OK, what would be the easiest way to get the packages to you? (You would probably need scalable-3p-base as well since scalable-3p-eigen3 depends on it.)

ferventcoder commented 7 years ago

How big are the files? you can just add .zip to the end of the extension for the package and attach it here.

And I'll only need the one with issues.

dschepler commented 7 years ago

scalable-3p-eigen3.3.3.2.nupkg.zip

ferventcoder commented 7 years ago

Hi @dschepler - what commands did you issue to create this package? I'm attempting to extract that file now and not having much luck (I wonder if there is something up with GitHub). Or it could be something on my side.

dschepler commented 7 years ago

nuget pack scalable-3p-eigen3.nuspec -NoPackageAnalysis -NonInteractive

(If I remember correctly, when I first created the packaging scripts, choco pack wouldn't work as a regular user so I just extracted the nuget command line that it was invoking.)

ferventcoder commented 7 years ago

I'd suggest giving choco pack another try. Especially if your nuget version is now above 3.4

dschepler commented 7 years ago

The new version created with choco pack seems to be working OK. (And it can still be extracted manually using nuget install, which is important for some of our customer installs where they need to have multiple versions of the package repository installed in different directories for different releases of our software.)

scalable-3p-eigen3.3.3.2.1.nupkg.zip