chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.23k stars 897 forks source link

Add option to skip file logging for Zip file extraction in the Get-ChocolateyUnZip and Install-ChocolateyZipPackage cmdlets #1332

Closed njlr closed 2 years ago

njlr commented 7 years ago

Choco times-out for large zip files (9, 500+ files).

Perhaps an option to disable the logging of each file would speed-up the process?

(Admin edit - notes):

Admin edit - Gitter screenshots The above link to Gitter may disappear as we have transitioned to Discord for chat, so capturing some screenshots of the conversation:

2021-11-13_21-10-51 2021-11-13_21-12-34 2021-11-13_21-13-06 2021-11-13_21-13-32 2021-11-13_21-14-03
ferventcoder commented 7 years ago

https://github.com/chocolatey/choco/blob/e96fb159e0957d9e2fee1e738d42dcc414957c91/src/chocolatey.resources/helpers/functions/Get-ChocolateyUnzip.ps1#L151 is where it sets the log level (currently -bb1). This switch would allow for the log detail to be missing.

This would also remove chocolatey's ability to use Uninstall-ChocolateyZipPackage as it would not be capturing the file list for removal, but if you are just unpacking into the package directory, this is okay anyway as that function is not necessary.

Workaround

Use Get-ChocolateyWebFile to bring down the zip, then take a dependency on 7zip package and use 7zip directly to unpack the files. Here's an example - https://chocolatey.org/packages/Vivaldi/1.9.818.44

gep13 commented 2 years ago

In order to make this work, there would need to be some upstream changes in the chocolatey.extension, so that the same logic could be applied there, when required.

pauby commented 2 years ago

In the release notes, we should call out that this will not be available in licensed versions until a release of the Licensed extension.

gep13 commented 2 years ago

A follow up issue for Chocolatey Licensed Extension has been created so that this work can be tracked.

https://github.com/chocolatey/chocolatey-licensed-issues/issues/319

AdmiringWorm commented 1 year ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: