search

chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.23k stars 897 forks source link

Wrong item set for overriding credentials when using remembered arguments during upgrade #2752

Closed TheCakeIsNaOH closed 2 years ago

TheCakeIsNaOH commented 2 years ago

What You Are Seeing?

During upgrading and using remembered argument, while overriding the password, certificate, and certificate password respectively, instead the username is being set to the wrong thing three times.

https://github.com/chocolatey/choco/blob/6f3fc1550148bb3ce8d75f6db2d3ca1528cf4587/src/chocolatey/infrastructure.app/services/NugetService.cs#L1004-L1006

What is Expected?

That the password, certificate, and certificate password are set, instead of the username.

How Did You Get This To Happen? (Steps to Reproduce)

N/A

System Details

N/A

Output Log

N/A

Full Log Output

~~~sh IF YOUR LOG CONTENT IS SHORT, PLACE IT HERE - WE NEED _ALL_ DETAILED OUTPUT BASED ON THE ABOVE TO BE ABLE TO PROVIDE SUPPORT (YOU WILL FIND THAT IN THE $env:ChocolateyInstall\logs\chocolatey.log between the `=====`) IF YOUR LOG CONTENT IS LONG, PLEASE LINK TO A GIST (see https://docs.github.com/en/github/writing-on-github/editing-and-sharing-content-with-gists/creating-gists) ~~~

AdmiringWorm commented 1 year ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: