chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.23k stars 897 forks source link

Change source type on source runners to be a generic string #2791

Closed AdmiringWorm closed 2 years ago

AdmiringWorm commented 2 years ago

Is Your Feature Request Related To A Problem? Please describe.

With the current implementation of source runners we are restricted to the source types that are defined in the SourceType enumeration, this makes it impossible to add new source runners in extension packages (like Chocolatey Licensed Extension) when we want/need to do this without adding another enumeration value in SourceType.

Describe The Solution. Why is it needed?

The solution would be to make this source type a generic string that can have any value, even values that Chocolatey CLI do not know about while making the existing SourceType enumeration obsolete.

Additional Context.

This came up as part of talk about adding new sources in Chocolatey Licensed Extension, and based on the work being done in #2693

This will be a minor breaking change to the API itself which will not be released as a major Chocolatey CLI release.

Related Issues

N/A

AdmiringWorm commented 1 year ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: