chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.05k stars 890 forks source link

(#3401) Update Proxy documentation #3414

Closed corbob closed 2 months ago

corbob commented 3 months ago

Description Of Changes

Update the wording of the Proxy help output to be clear about what is expected.

Motivation and Context

The help output is not clear that Proxy Bypass List is expected to be a regular expression.

Testing

  1. Ran build script.
  2. Ran GenerateDocs.ps1
  3. Copied files over to chocolatey/docs repository to verify updates.

Operating Systems Testing

N/A This is just an update to the help output/docs.

Change Types Made

Change Checklist

Related Issue

corbob commented 3 months ago

I was going back and forth on how to review these PRs, hence why it was ready, then draft, now ready again. I have settled upon this review proposal:

  1. This PR is reviewed for the wording update of the proxy help output.
  2. Any changes to the wording are run through GenerateDocs.ps1 and copied over to the Docs PR.
  3. After this PR is merged: the Docs PR (chocolatey/docs#958) is updated to clean up the commits for a final review/merge.
gep13 commented 2 months ago

@vexx32 can I ask that you put your eyes on this PR, and provide any feedback. Thanks!