chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.04k stars 890 forks source link

(build) Update to latest Recipe package #3441

Closed gep13 closed 1 month ago

gep13 commented 1 month ago

Description Of Changes

Going forward, rather than signing PowerShell scripts on every build, which is a bit of a waste of effort, we are only going to sign the scripts when required. The changes required to to do have been implemented in 0.28.0 of Chocolatey.Cake.Recipe under issue #149.

Motivation and Context

This commit updates the Chocolatey CLI build to make use of it. This includes changes the DAG for tasks to depend on the new Verify-PowerShellScripts task, rather than the Sign-PowerShellScripts task. In addition, a new Func is created to find the scripts that need to be verified, since this can, and is, sometimes different from the list of files that need to be signed.

Testing

This PR should be tested in combination with the PR into Chocolatey.Cake.Recipe, along with a new Build Configuration added to the settings.kts file from TeamCity.

Operating Systems Testing

N/A

Change Types Made

Change Checklist

Related Issue

N/A

gep13 commented 1 month ago

@Windos this change will fail the build, due to the check for the 0.28.0 version of Chocolatey.Cake.Recipe.

gep13 commented 1 month ago

@Windos and I had a conversation to discuss the changes in this PR, and are happy to proceed with the changes, once the CI builds complete.