chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.04k stars 890 forks source link

(#3465) Allow building an MSI during outside of tagged commits. #3466

Open corbob opened 2 weeks ago

corbob commented 2 weeks ago

Description Of Changes

Update the Recipe used to default to not build an MSI. Update the CI configurations to allow building the MSI with the addition of the --shouldBuildMsi=true parameter.

Motivation and Context

Ease the experience of making adjustments to the MSI. Allow us to get an MSI more regularly for testing.

Testing

  1. Ran ./build.bat --target=Build-Msi
  2. Noted that it failed to build as a previous task was skipped.
  3. Ran ./build.bat --target=Build-Msi --shouldBuildMsi=true
  4. Noted that it completed successfully.
  5. Checked the code_drop/Artifacts and code_drop/MSIs/en-US directories to confirm that an MSI was generated.
  6. Monitored the GHA for this PR to note that an MSI was generated.
  7. Monitored the Team City build for this PR to note that an MSI was not generated (because it's not a tagged build and the settings haven't been merged yet)

Operating Systems Testing

Change Types Made

Change Checklist

Related Issue

Fixes #3465

corbob commented 2 weeks ago

Note: The MSI task in the GHA ran successfully, but Chocolatey.Cake.Recipe doesn't currently try to upload the MSI on GHA: https://github.com/chocolatey/Chocolatey.Cake.Recipe/blob/e4ac5d739a594f24d62c8502dfa4573da59f5267/Chocolatey.Cake.Recipe/Content/build.cake#L482