Add uninstall PowerShell helper for VSIX (visual studio extension)

chocolatey / choco

Chocolatey - the package manager for Windows

https://chocolatey.org

Other

10.34k stars 903 forks source link

Add uninstall PowerShell helper for VSIX (visual studio extension) #389

Open timabell opened 9 years ago

timabell commented 9 years ago

Hi, hope you don't mind me asking here. I'm trying to create a package for a visual studio extension (vsix). I've got the install working; now I am wondering about allowing uninstall, it would be nice if I could provide that but there doesn't seem to provision for it.

I was following the instructions at https://github.com/chocolatey/choco/wiki/HelpersInstallChocolateyVsixPackage but can't find an equivalent uninstall command.

C:\Program Files (x86)\Microsoft Visual Studio 14.0>vsixinstaller /? does show an uninstall switch.

I assume it's just not implemented? Cheers

Thanks for a great tool.

ferventcoder commented 9 years ago

@timabell You are correct, an uninstall helper just has not been added. If you want to add one, we accept pull requests. Just make sure you read over our Contributing doc prior to ensure you set up commits correctly and can sign the CLA. :)

timabell commented 9 years ago

Okay thanks for confirming. I'll pass on the PR then as I'm not keen on CLAs.

ferventcoder commented 9 years ago

No worries.

kevindaub commented 9 years ago

I was going to look into this one. At first glance, it looks like the uninstall and install will have very similar code (i.e. like locating VS Install directory).

Would creating another function like Get-VisualStudioInstallDir or Get-VisualStudioVersion be okay to add as a helper function as well?
Also, are there any powershell unit tests or integration tests that should be included (I see C#, but no powershell)?

ferventcoder commented 9 years ago

C# integration tests are in for testing different behaviors of packages, installing and uninstalling, but don't actually test making changes to the system itself. I've been thinking about how to introduce those kinds of tests without having to change system state. You are welcome to make suggestions.

All of the PowerShell functions will be reimplemented as C# PowerShell cmdlets at some point, so something else to consider.

kevindaub commented 9 years ago

I'd prefer to keep in C#, so maybe that's the path I'll go down. It also allows easier testing.