search

chocolatey / chocolatey-licensed-issues

Issues for Licensed Editions of Chocolatey
19 stars 13 forks source link

Self-Service - Warn about missing admin privileges if using agent but --run-actual is passed #16

Open pascalberger opened 7 years ago

pascalberger commented 7 years ago

What You Are Seeing?

If I have background agent running Chocolatey no longer warns if executed without administrative privileges, which makes sense.

What is Expected?

If choco install is run with the --run-actual parameter choco should warn about missing administrative privileges, even if background mode is active.

How Did You Get This To Happen? (Steps to Reproduce)

ferventcoder commented 7 years ago

I'm guessing you followed the instructions at https://chocolatey.org/docs/features-agent-service#background-mode-setup and ran:

choco feature disable -n showNonElevatedWarnings

ferventcoder commented 7 years ago

This turns it off for all. Are you wanting a feature like this: showNonElevatedWarningsToAdmins (or whatever is consistent with naming)?

pascalberger commented 7 years ago

Yes, I have run showNonElevatedWarnings disabled. Not sure if showNonElevatedWarningsToAdmins is what I want. I would expect Chocolatey to not warn about elevation if using background service, except if --run-actual parameter is passed to the command. So something like disableElevatedWarningsIfBackgroundModeIsUsed might be more appropriate.

ferventcoder commented 7 years ago

@pascalberger you will be able to not route through background service when running choco as an administrator (read: with or without elevation) with a feature in v1.12.0 - see https://github.com/chocolatey/chocolatey-licensed-issues/issues/14. So the name of the feature should make sense to explain that it would only show that warning to admins if they are in a non-elevated status.

In other words, you won't need to pass --run-actual if you are an administrator and have flipped on this feature.

ferventcoder commented 7 years ago

Fixed the wording above