chocolatey / chocolatey-licensed-issues

Issues for Licensed Editions of Chocolatey
19 stars 13 forks source link

Ensure that features that have been removed from Chocolatey CLI can no longer be set using feature command #293

Closed sync-by-unito[bot] closed 2 years ago

sync-by-unito[bot] commented 2 years ago

Description

With the release of Chocolatey v0.12.0 we deprecated a feature. All the code for this feature was removed from the code case, however, after upgrading an installation of Chocolatey, the corresponding entry can still be found in the chocolatey.config file.

This by itself doesn't actually cause a problem, and it needs to be left in the file in order to allow for backwards compatibility, however, when executing the following command on Chocolatey v0.12.0:

choco feature enable --name=scriptsCheckLastExitCode

It will output that the feature was enabled, when actually, nothing in the current codebase will do anything with this.

In any given Chocolatey version, we need to support only the features that exist in that release, nothing else, even though they exist in the chocolatey.config file. This is different to the config values, which are intended to be extended through Chocolatey Extensions, etc. However, features are specific to Chocolatey.

Why Is It Needed

This handling is implemented in vNext of Chocolatey, however an additional update is needed here to Chocolatey Licensed Extension to ensure that using Licensed features do not break.

Related Issues and Tickets

https://github.com/chocolatey/choco/issues/2538

┆Issue is synchronized with this Gitlab issue by Unito ┆Milestone: 4.0.0