chocolatey / docs

https://docs.chocolatey.org - new docs website
Apache License 2.0
151 stars 165 forks source link

(#1007) Retain Tab Component CSS #1008

Closed st3phhays closed 3 weeks ago

st3phhays commented 3 weeks ago

Description Of Changes

The purgeCSS flow has been adjusted to ensure that any classes on Astro Components are retained. This ensures that the Astro Components are styled correctly.

In addition, this is now checking for a value when trigger automation for tabs with a multi version. This ensures no invalid JSON errors.

Motivation and Context

We want this to render correctly.

Testing

  1. Review changes at https://github.com/chocolatey/choco-theme/pull/408
  2. Run this PR
  3. Go to http://localhost:5086/en-us/central-management/setup/database/#database-authentication-scenarios
  4. Play with the tab container, and notice it's "normal"
  5. In your browser, open up the Dev Tools, and notice there are no Red JS errors.
  6. If all appear good, merge the PR at https://github.com/chocolatey/choco-theme/pull/408
  7. Notify @st3phhays to release and update choco-theme here and take this PR out of draft.
  8. After updating, this can be merged

Change Types Made

Change Checklist

Related Issue

Fixes #1007

steviecoaster commented 3 weeks ago

@st3phhays This is ready for you

st3phhays commented 3 weeks ago

@steviecoaster choco-theme has been updated, this is ready to merge now.