search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

[REQUIREMENT] Don't include update script for AU in package #159

Open pascalberger opened 7 years ago

pascalberger commented 7 years ago

A validation rule which checks for the existence of an AU update script (update.ps1) would be nice.

gep13 commented 7 years ago

I tend to agree with this, however, I don't think it would be a rule that would fail the validation process, unless we inspect the file in question for something specifically that points to AU being used. i.e. having a file called update.ps1 in the package itself wouldn't be enough, would it?

pascalberger commented 7 years ago

Better than a filecheck would be to check for a file containng an import-module au statement. But checking for update.ps1 and raise a suggestion might also work.

gep13 commented 7 years ago

Ah, good suggestion. I think the presence of the update.ps1 and usage of import-module au would be enough to fail validation, and to push it back to the maintainer.