search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

[Requirement] Links must actually go to an existing url #160

Closed ferventcoder closed 4 years ago

mkevenaar commented 5 years ago

I would suggest that the package validator requires that all URLs in the nuspec file (e.g. docsUrl, mailinglistUrl) result in a valid HTTP status (2xx, 3xx). A 500 might be considered as a warning, as there could be something wrong with the remote server. Take a look at this page for more status codes.

mkevenaar commented 4 years ago

@gep13 the changes you have merged do not validate URL inside markdown fields. Do you still want that?

gep13 commented 4 years ago

@mkevenaar yes, I think that would make sense.

mkevenaar commented 4 years ago

@gep13 I have opened #196 for this.

pauby commented 4 years ago

While I was putting together chocochecks I came across issues where valid URL's were actually being flagged as 404's. They work fine in the browser but not using, in my case, Invoke-WebRequest.

What reminded me to come and post this here was this in Gitter.

Unfoirtunately, I don't have an answer for you as I spend a small amount of time looking at it with no result. I haven't had any further time looking at it. So this is more of an FYI / I've seen this issue.