This line causes erroneous detection and failure of packages that use any variable name that contains installArguments as a substring.
Real-world effect can be seen here where the uninstall script uses a registry key called UninstallArguments and is being caught & falsely failed by this validation check.
seems like a better check would be .Contains("$installArguments"), etc
bc3tech
commented
6 years ago
This line causes erroneous detection and failure of packages that use any variable name that contains
installArgumentsas a substring.Real-world effect can be seen here where the uninstall script uses a registry key called
UninstallArgumentsand is being caught & falsely failed by this validation check.seems like a better check would be
.Contains("$installArguments"), etc