search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

ScriptsContainTooManyLines shouldn't count signature lines #183

Open clairernovotny opened 6 years ago

clairernovotny commented 6 years ago

This warning/check should exclude the line-count added by signed scripts.

It's flagging a signed ps1 file as being too long.

https://github.com/chocolatey/package-validator/wiki/ScriptsContainTooManyLines

To repro, look at the ps1 in the NuGetPackageExplorer package; you'll see an example of a signed powershell script.

gep13 commented 6 years ago

@onovotny this is a good suggestion. I notice that this isn't causing you a "problem" just now, as this is just a guideline, rather than a requirement, but this definitely makes sense to look at.