(GH-160) Require URLs to be valid

chocolatey / package-validator

Windows service to validate packages conform to package standards

Apache License 2.0

31 stars 29 forks source link

(GH-160) Require URLs to be valid #184

Closed mkevenaar closed 4 years ago

mkevenaar commented 5 years ago

These checks would verify that the following URLs are valid:

nuspec
- IconUrl
- DocsUrl
- BugTrackerUrl
- MailingListUrl
- ProjectSourceUrl
- ProjectUrl
- LicenseUrl
- WikiUrl
- PackageSourceUrl
- Description (parse for all URLs)
- ReleaseNotes (parse for all URLs)

gep13 commented 5 years ago

Relates to #160

mkevenaar commented 5 years ago

Wiki page created: https://github.com/chocolatey/package-validator/wiki/InvalidUrlProvided

Once complete and approved, the Home and _Sidebar wiki page should be edited to include this page.

gep13 commented 5 years ago

@ferventcoder what are your thoughts on this PR? Aside from perhaps a squash of some of the commits, in principal, I think that this is a good addition to the package-validator.

mkevenaar commented 5 years ago

Aside from perhaps a squash of some of the commits

I have squashed the commits into 2 commits.

mkevenaar commented 5 years ago

I have removed the URL validation from the files attached to the nupkg by request of @ferventcoder.

gep13 commented 4 years ago

@mkevenaar your changes have been merged, thanks for your contribution 👍

mkevenaar commented 4 years ago

Thanks for merging this @gep13!