search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

Incorrect URL in rule #187

Closed gep13 closed 4 years ago

gep13 commented 5 years ago

In this rule:

https://github.com/chocolatey/package-validator/blob/master/src/chocolatey.package.validator/infrastructure.app/rules/CopyRightAndAuthorFieldsShouldntContainEmailRequirement.cs

It links to this URL:

https://github.com/chocolatey/package-validator/wiki/CopyrightAndAuthorFieldsShouldntContainEmail

However, this URL doesn't exist. Instead, it should point to the following URL:

https://github.com/chocolatey/package-validator/wiki/NuspecDoesNotContainEmail

AdmiringWorm commented 5 years ago

The PackageIdUsesUnderscoreNotes rule also links to a page that doesn't exist.

https://github.com/chocolatey/package-validator/blob/master/src/chocolatey.package.validator/infrastructure.app/rules/PackageIdUsesUnderscoresNote.cs

Links to: https://github.com/chocolatey/package-validator/wiki/PackageIdUsesUnderscores

Can't find a wiki page that matches that rule either.

mkevenaar commented 4 years ago

I have fixed the URL for the CopyRightAndAuthorFieldsShouldntContainEmailRequirement.cs file.

I think we need to create a new wiki document for the PackageIdUsesUnderscoresNote.cs file (https://github.com/chocolatey/package-validator/wiki/PackageIdUsesUnderscores)

gep13 commented 4 years ago

@mkevenaar said... I think we need to create a new wiki document for the PackageIdUsesUnderscoresNote.cs

I have created a stub page in the wiki for this.