search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

(GH-200) Make SecurityProtocol changes immediately #201

Closed gep13 closed 4 years ago

gep13 commented 4 years ago

Changes to the SecurityProtocolType should be made before creating any request objects, otherwise those settings aren't applied to the request object that already exists.

Relates to #200

mkevenaar commented 4 years ago

@gep13 To make things easier to validate in the future, extra tests containing the URLs from #200 might be a good idea. But they would be harder to maintain as URLs could change and therefore the tests could fail.

@ferventcoder your thoughts?

gep13 commented 4 years ago

@mkevenaar said... extra tests containing the URLs from #200 might be a good idea

I had the same thought. I have added some tests to include the URL's that came up in issue #200