search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

Whalebird URLs failing validation #234

Closed flcdrg closed 4 years ago

flcdrg commented 4 years ago

https://chocolatey.org/packages/whalebird/4.1.3

All URLs look ok to me

ferventcoder commented 4 years ago

Two of them are not showing up on the page. Is it failing on missing urls?

ferventcoder commented 4 years ago

@gep13 ^^

FullofQuarks commented 4 years ago

I am able to reproduce locally.

Looks like the error is a 429 "too many requests" while validating the URLs in the releaseNotes:

2020-06-25 17:59:47,476 13 [INFO ] - Running validation rules... 2020-06-25 18:00:34,517 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1518 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,590 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1517 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,649 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1497 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,704 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1515 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,761 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1512 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,824 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1550 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,895 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/pull/1513 - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:34,957 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop/issues - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:35,019 13 [WARN ] - Error validating Url https://github.com/FullofQuarks/chocolatey-packages/tree/master/automatic/whalebird - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:36,516 13 [WARN ] - Error validating Url https://github.com/h3poteto/whalebird-desktop - The remote server returned an error: (429) too many requests. 2020-06-25 18:00:36,851 13 [DEBUG] - Sending message 'PackageValidationResultMessage' out if there are subscribers... 2020-06-25 18:00:36,853 13 [INFO ] - whalebird v4.1.3 FAILED validation.

flcdrg commented 4 years ago

I think you might have hit on something. GitHub throttles traffic if you don't supply an auth token and I'm not sure that the validator is handling GitHub urls for this case.

gep13 commented 4 years ago

@FullofQuarks out of interest... were you running a local version of package-validator to get the output that you showed above?

I can replicate this on the package-validator machine, and I believe that I have an explanation. Basically, the shear number of URL's (all of which go to GitHub) in the release notes sections of the nuspec is causing the package validator to trip the too many requests 429 error from GitHub.

I have a very crude work around that we can employ to prevent this from happening, namely to add a small delay between each request, so that we don't trip the too many requests error.

FullofQuarks commented 4 years ago

@gep13 Correct, I was running a local version of package-validator

gep13 commented 4 years ago

@FullofQuarks I have deployed a fixed version of package-validator, which "works around" this problem. Your package has now been correctly validated.

Please let us know if you run into any other problems.

@FullofQuarks said... Correct, I was running a local version of package-validator

Not many people go to that length to test things out! Kudos!