search

chocolatey / package-validator

Windows service to validate packages conform to package standards
Apache License 2.0
31 stars 29 forks source link

Non-Versioned Dependency False Alarm #84

Closed wjk closed 8 years ago

wjk commented 8 years ago

I have just pushed an update to the bfg-repo-cleaner package that addressed, among other things, the lack of a version constraint in the nuspec. However, following the update, the validator still flags the use of an non-versioned dependency. Please see attached screenshots.

guidelines versioned-dependency

ferventcoder commented 8 years ago

Likely a bug...

ferventcoder commented 8 years ago

https://github.com/chocolatey/package-validator/blob/a5ba39c3daf0a19ed71c6624dd1f098ffe1454b4/src/chocolatey.package.validator/infrastructure.app/rules/DependencyWithNoVersionGuideline.cs#L29

Hmmm. We do have some specs for this one...maybe not enough.

ferventcoder commented 8 years ago

@wjk it was due to the spec not covering the scenario of only having a minimum version specified. Also to our misunderstanding of what that scenario would look like (we thought we were covering that scenario). I updated the specs to show this scenario and then fixed the code. See the linked commit.