Optimize computeTightestPoint & propagate in ParetoMaximizer - fixes #1026

chocoteam / choco-solver

An open-source Java library for Constraint Programming

http://choco-solver.org/

BSD 4-Clause "Original" or "Old" License

690 stars 143 forks source link

Closed jsimomaa closed 1 year ago

jsimomaa commented 1 year ago

fixes #1026

jsimomaa commented 1 year ago

I tried to reproduce the failing test:

Error:  Failures: 
Error:    LNSTest.test1:118->knapsack20:105 expected [8372] but found [7812]

I get different outcomes of this test - sometimes it succeeds and sometimes it fails with different found-value 🤔

cprudhom commented 1 year ago

I will wait until the improvements are stable before validating and launching the tests

jsimomaa commented 1 year ago

I will wait until the improvements are stable before validating and launching the tests

Yep, I'd say they now are. These changes improved the performance of my case quite significantly.

Please go ahead with the validation and testing, thank you.

cprudhom commented 1 year ago

Thank you for your contribution