use square when possible and stronger filtering

chocoteam / choco-solver

An open-source Java library for Constraint Programming

http://choco-solver.org/

BSD 4-Clause "Original" or "Old" License

683 stars 137 forks source link

use square when possible and stronger filtering #1054

Closed jgFages closed 11 months ago

jgFages commented 12 months ago

practical interest to be confirmed by experiments

sonatype-lift[bot] commented 12 months ago

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

ArthurGodet commented 11 months ago

I've simplified the code of updateHoles methods. More especially, I've removed dead code (which gave a welcome speed up, some tests taking only 30% of times compared to what they took before) and standardised the code between similar functions.

@jgFages If you are ok with modifications, I think we can merge the code.

jgFages commented 11 months ago

@ArthurGodet the git history has been corrupted with merge commits (some from 2022), this would make history harder to analyze, so I close this PR and I create a new one here : https://github.com/chocoteam/choco-solver/pull/1055

I will push a last modification and comment your suggestions there