search

chocoteam / choco-solver

An open-source Java library for Constraint Programming
http://choco-solver.org/
BSD 4-Clause "Original" or "Old" License
683 stars 137 forks source link

[Documentation] Wrong specs in Implied and Reif constraints/propagators #1087

Open 363734 opened 4 months ago

363734 commented 4 months ago

Hi,

When reading the code about implied and reification constraints, I noticed there are a few specifications issues (probably copy-paste related).

Both constraints share the same spec image image Which is correct for Reification but not true for Implication. In addition, they both use (in their constructor) the constraint name 'ConstraintsName.REIFICATIONCONSTRAINT' which may be correct if you use it as a category, but not if you use the name as the name of the actual constraint.

On the propagator side, they also share the same spec image image Which is correct for Implication but not correct for Reification

Kind regards, Hélène