Closed juliebehr closed 8 years ago
Has Rafal already converted these?
I don't think so? He pointed me to how to implement the new ions, but I think / assumed he already had xmls to work with
Let me see what I can work out here!
Hmmm, that worked ok for me actually.
That PDB you're using - is it from their website or something different? I'm surprised it's throwing CONECT error.
Re converting to xml: you just need the conversion script: https://github.com/choderalab/openmm/tree/forcefield_conversion_bonanza/devtools/forcefield-scripts/amber (just take amber2openmm.py if you're doing only this small conversion)
Make a leaprc mg
:
loadamberparams frcmod.mg
loadoff mg.lib
and call: python amber2openmm.py --input mg --input-format leaprc
and you've got an mg.xml
: https://gist.github.com/rafwiewiora/5baa72e0810d0cb118ab952736ab9a1c - this is as it comes out, unfortunately you need to manually change the element of the XZ atom type to Mg - it has F here because if the element is not specified Parmed looks by mass. There isn't really a way to fix this - this is an unusual case with a lower mass than what Mg would have.
We should add all these metals into 7.1 once the main conversion PR goes in - I'll work on adding tests for these models to amber2openmm.py .
Wonderful, thank you @rafwiewiora ! And no worries about the manual edit, that's what I've had to do for plenty of steps in this project!
No problem at all!
Oh, just realized! The element="H"
for the dummy atoms is also wrong - for those you need to make them element None so they're treated as dummy atoms in OpenMM (i.e. just delete the element attribute from the XML - I can't remember if leaving it as element="" also works, it should, but not having the attribute definitely works).
This should be fully working: https://gist.github.com/rafwiewiora/d265377cd3bd5660cba9ae191676790a
Also just some things I remembered after we chatted yesterday - some problems to watch out for:
addExtraParticles
will not like it (if you load in a topology without the dummy atoms and want to add them)PDBFile('name.pdb', extraParticleIdentifier=''
). Otherwise it would try to find element based on the name of the dummy atoms, and it will make them deuterium for you, which is very annoying :) Oh yes I noticed the H! So I can just delete them, perfect. And excellent points, I think I know how to deal with the first and I noticed the second yesterday and was very confused by it, so this makes much more sense.
Cool! If anything else comes up, shoot me a comment here!
Addressed in https://github.com/choderalab/AURKA_UMN/pull/38 (keeping open until all RUNS are prepared, just in case).
I think there must have been updates to tleap since the time the Sept lab posted their parameters and use directions which render them unusable. When I try to follow their steps in tleap, I end up with