search

choderalab / LiquidBenchmark

GNU General Public License v2.0
0 stars 6 forks source link

More edits #42

Closed kyleabeauchamp closed 9 years ago

kyleabeauchamp commented 9 years ago

This should implement most of the requested changes in the previous round of edits.

jchodera commented 9 years ago

Looking good!

I just noted a small issue with quotation marks on lines 69-70 of the rendered PDF.

jchodera commented 9 years ago

That's here in the diff: https://github.com/choderalab/LiquidBenchmark/pull/42/files#diff-750ef559d0038ddbd837666a948de896R170

jchodera commented 9 years ago

I think we still need to put something in there about your ThermoML Archive retrieval tool once we have that sorted, but maybe we can raise a separate issue about that? I think that's a key part of the whole message here.

kyleabeauchamp commented 9 years ago

Maybe we can email Kenneth to see whether he wants to describe the tool in the manuscript or just on the Github. I'm willing to go with his needs on this one, as he's in charge of the ThermoML.

jchodera commented 9 years ago

Maybe we can email Kenneth to see whether he wants to describe the tool in the manuscript or just on the Github. I'm willing to go with his needs on this one, as he's in charge of the ThermoML.

Sounds good. I'll send the email, CCing you.