search

choderalab / assaytools

Modeling and Bayesian analysis of fluorescence and absorbance assays.
http://assaytools.readthedocs.org
GNU Lesser General Public License v2.1
18 stars 11 forks source link

small update to xml2png plotting singlet assay #116

Closed sonyahanson closed 6 years ago

sonyahanson commented 7 years ago

Small update to xml2png plotting for single wavelength assay.

@MehtapIsik mentioned that the Lstated was hardcoded into this plotting script in xml2png, so now this is plotted by 'column index'. Also changed the plotting to dots and matched the coloring scheme to other plots made by assaytools.

This is good to merge on my end, but it'd be great if someone else could check in case I've used an older version of matplotlib that doesn't work for others. @MehtapIsik, @bas-rustenburg, and @jchodera should all have this power (run xml2png --type singlet_384 *.xml on any single wavelength 384-well dataset we've collected).

jchodera commented 7 years ago

Why not add a travis test to do the same thing and make sure it never breaks?

You can add a simple command-line call to xml2png after this line: https://github.com/choderalab/assaytools/blob/master/.travis.yml#L34

sonyahanson commented 7 years ago

All checks have passed!

jchodera commented 7 years ago

Woohoo!

jchodera commented 7 years ago

Feel free to merge.

jchodera commented 7 years ago

Whoops!