search

choderalab / assaytools

Modeling and Bayesian analysis of fluorescence and absorbance assays.
http://assaytools.readthedocs.org
GNU Lesser General Public License v2.1
18 stars 11 forks source link

Fixing quickmodel trace access #130

Closed steven-albanese closed 6 years ago

steven-albanese commented 6 years ago

Looks like the problem is with the way the traces are being accessed. Opening a PR to see if I can fix this!

steven-albanese commented 6 years ago

Ok I've got this working locally now! We'll see if the tests pass, or if there's another issue.

jchodera commented 6 years ago

If you're updating to use a new aspect of the pymc API, make sure you pin to the minimum pymc version with this new API!

jchodera commented 6 years ago

(Unless, of course, this way of using the API is backwards-compatible!)

steven-albanese commented 6 years ago

Ok! I'll have to dig into the pymc2 docs and see when they switched over to this API. I'm not sure if it's backwards compatible or not

steven-albanese commented 6 years ago

Also -- where do I pin a package?

jchodera commented 6 years ago

Both the build and run sections here, and then later in the conda recipe!

steven-albanese commented 6 years ago

Ok -- I think I've correctly pinned the version of pymc we need, and I've also thrown in a quick script to plot traces from the pickle object that gets written out.

jchodera commented 6 years ago

@steven-albanese : Can you commit your changes to devtools/conda-recipe/meta.yaml?

steven-albanese commented 6 years ago

I think this might be ok to merge unless there are other concerns!

jchodera commented 6 years ago

Nope!