choderalab / chiron

Differentiable Markov Chain Monte Carlo
https://github.com/choderalab/chiron/wiki
MIT License
14 stars 1 forks source link

Consistent treatment of frequency reporters #19

Open wiederm opened 7 months ago

wiederm commented 7 months ago

Currently, we save the parameter that controls the frequency reporters are called in the Sampler class. We pass it in its __init__ method --- should we move this to the run method where we also set the number of sampling steps?

Also, we are currently saving coordinate sets for debugging in the sampler, should we move this to the reporter (this would only require to not write the buffer to disk but keep it in memory).

_Originally posted by @chrisiacovella in https://github.com/choderalab/chiron/pull/18#discussion_r1453739301_