search

choderalab / espaloma

Extensible Surrogate Potential of Ab initio Learned and Optimized by Message-passing Algorithm 🍹https://arxiv.org/abs/2010.01196
https://docs.espaloma.org/en/latest/
MIT License
203 stars 23 forks source link

Nonbonded forces not properly subtracted from reference derivative #139

Closed kntkb closed 1 year ago

kntkb commented 1 year ago

Perhaps we need to multiple -1 to the forces to get the derivative. It looks like we're subtracting the forces from the reference derivative (u_ref_prime).

https://github.com/choderalab/espaloma/blob/master/espaloma/data/md.py#L471 https://github.com/choderalab/espaloma/blob/master/espaloma/data/md.py#L497