using `dgl.to_homogeneous` instead of the old deprecated name.

choderalab / espaloma

Extensible Surrogate Potential of Ab initio Learned and Optimized by Message-passing Algorithm 🍹https://arxiv.org/abs/2010.01196

https://docs.espaloma.org/en/latest/

MIT License

202 stars 23 forks source link

using `dgl.to_homogeneous` instead of the old deprecated name. #173

Closed ijpulidos closed 11 months ago

ijpulidos commented 11 months ago

DGL method is now named to_homogeneous.

This should fix tests breaking on downstream packages, such as in https://github.com/openmm/openmmforcefields/actions/runs/5555278333/jobs/10146203523?pr=289#step:9:1959

mikemhenry commented 11 months ago

@ijpulidos is this one ready to go? Did our unit tests not catch this because of a DGL version pin?

ijpulidos commented 11 months ago

@ijpulidos is this one ready to go? Did our unit tests not catch this because of a DGL version pin?

I think the issue is that we are not really testing this, we should probably write a test that uses it but I honestly don't think I could come up with one before the release (if we want to release today).

codecov-commenter commented 11 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5b5fb04). Click here to learn what that means. The diff coverage is n/a.